Difference between revisions of "Template talk:SongDetails"

From JoCopedia
Jump to navigation Jump to search
(→‎Infobox, second version: template autoadding to Songs category)
Line 48: Line 48:
 
:: Good catch re: [[Better/Videos]] - I'll take that template out in a moment. That makes sense, that it'll work as expected on song pages anyway. I'm okay with that, just wanted to make sure we were on the same page. I agree that the Related Links probably belong (well, at least they look better) before the jonathancoulton.com links. (And it looks as though I clobbered my own signature somehow. I don't know what I did. Oh, wait, it looks like I typed five tildes instead of four. Whoops!) --[[User:Bry|Bry]] 00:22, 29 April 2008 (EDT)
 
:: Good catch re: [[Better/Videos]] - I'll take that template out in a moment. That makes sense, that it'll work as expected on song pages anyway. I'm okay with that, just wanted to make sure we were on the same page. I agree that the Related Links probably belong (well, at least they look better) before the jonathancoulton.com links. (And it looks as though I clobbered my own signature somehow. I don't know what I did. Oh, wait, it looks like I typed five tildes instead of four. Whoops!) --[[User:Bry|Bry]] 00:22, 29 April 2008 (EDT)
 
::Actually, while taking out the template from [[Better/Videos]], I've noticed that the SongDetails template also adds the page to [[:Category:Songs]]. In the revision, maybe have that happen if BASEPAGENAME equals PAGENAME and all that? --[[User:Bry|Bry]] 00:27, 29 April 2008 (EDT)
 
::Actually, while taking out the template from [[Better/Videos]], I've noticed that the SongDetails template also adds the page to [[:Category:Songs]]. In the revision, maybe have that happen if BASEPAGENAME equals PAGENAME and all that? --[[User:Bry|Bry]] 00:27, 29 April 2008 (EDT)
 +
 +
::: It occurs to me that it would be a little bit more efficient for the server and (more importantly) a fair bit easier to read if the code for making the infobox work on subpages was removed. I've gone ahead and removed that code for now (since we can always revert).
 +
 +
::: [[User:Wesley/SongNav]] will always add the current page to the Songs category, but will result in a bunch of broken (red) links when used on a subpage now. So we shouldn't really need to say "only add this page to Category:Songs if it's not a subpage" because the box shouldn't be on a subpage to begin with, and should be removed. Does that seem reasonably...reasonable? [[User:Wesley|Wesley]] 00:53, 29 April 2008 (EDT)

Revision as of 00:53, 29 April 2008

New SongDetails?

User:Wesley/Infobox

I've whipped up a little infobox based on the current SongDetails, but with the Wikipedia Infobox look. As a bonus, it also gets rid of the bug where, on IE7, the lines from the headings run through the SongDetails box.

Since the SongDetails template is included from over 70 pages, I figure I'd just post about it here instead of replacing the existing SongDetails. Any bugs/problems? Suggestions?

Wesley 20:28, 28 April 2008 (EDT)

I like it very much, looks much more wikiesque! Great job! Haven't noticed any bugs with it but if I do I'll be sure to let you know here. ~ Percephene ~ talk contribs 12:42, 29 April 2008
I like it as well, Wesley. I would like to throw in a perhaps-radical suggestion: Remove the SongNav template from song main pages and do the links in the infobox. What do you guys think? (I've long thought the SongNav took up prime real estate on the main page that it didn't really deserve.) --Bry 21:21, 28 April 2008 (EDT)
I like the idea too. The current SongNav gets particularly annoying on narrower screens, where it's sometimes three or four lines tall. Look for changes in the infobox on the right as changes occur. (If you don't like the idea, though, now's your chance to object! :) Wesley 22:14, 28 April 2008 (EDT)
On second thought, look for changes over at User:Wesley/SongNav. I'll keep User:Wesley/Infobox as it is so we can compare later. Wesley 22:18, 28 April 2008 (EDT)

Infobox, second version

User:Wesley/SongNav Here's Wesley's other version of the infobox, with song-nav included. (One thing I might note: I'd like to keep the albums as links, as they are on the original SongDetails template.) -- Bry 23:20, 28 April 2008 (EDT)

I totally missed that--thanks Bry!
Yep, here's the infobox with the SongNav links built in. When it's on the main page of the song, the song title at the top won't actually be a link. As before: bugs? suggestions? Wesley 23:44, 28 April 2008 (EDT)
Where'd my name go in my sig above? (I've added it back now.) My comments are at User talk:Wesley/SongNav, but to summarize, I'd personally want to keep the SongNav on the subpages (but lump it in with the infobox on the main song page), and I think I'd put the "related links" lower on the infobox. (Actually, I think I wouldn't put them anywhere because I'm too much of an oaf to do any of this myself. But I'm happy to harp on the fruits of other people's labors...) --Bry 23:49, 28 April 2008 (EDT)
Oops, sorry if I clobbered your signature there :S And I've just now read your comments here and in User talk:Wesley/SongNav, and here's the contents of my brain in convenient bullet form:
  • I saw, in Special:Whatlinkshere/Template:SongDetails, that Better/Videos uses the SongDetails template. That's why the sidebar has been made to work properly on subpages. It was only a few lines of code, and doesn't affect how the infobox works while on the main song page. More importantly, it's very easy to strip out if we decide for sure not to have the infobox on any subpages :)
  • I agree, having the Related Links section between the album art and the album name is a pretty bad idea. Having said that, I ask you all: should it go before or after the links to the blog and the store? (I'm a little partial to having them before the links, so I'll try that first)
  • Please, by all means, do harp! It's hard to see the bigger picture while writing code, even if it's just wiki-code. It's great to have input like this :D
Good catch re: Better/Videos - I'll take that template out in a moment. That makes sense, that it'll work as expected on song pages anyway. I'm okay with that, just wanted to make sure we were on the same page. I agree that the Related Links probably belong (well, at least they look better) before the jonathancoulton.com links. (And it looks as though I clobbered my own signature somehow. I don't know what I did. Oh, wait, it looks like I typed five tildes instead of four. Whoops!) --Bry 00:22, 29 April 2008 (EDT)
Actually, while taking out the template from Better/Videos, I've noticed that the SongDetails template also adds the page to Category:Songs. In the revision, maybe have that happen if BASEPAGENAME equals PAGENAME and all that? --Bry 00:27, 29 April 2008 (EDT)
It occurs to me that it would be a little bit more efficient for the server and (more importantly) a fair bit easier to read if the code for making the infobox work on subpages was removed. I've gone ahead and removed that code for now (since we can always revert).
User:Wesley/SongNav will always add the current page to the Songs category, but will result in a bunch of broken (red) links when used on a subpage now. So we shouldn't really need to say "only add this page to Category:Songs if it's not a subpage" because the box shouldn't be on a subpage to begin with, and should be removed. Does that seem reasonably...reasonable? Wesley 00:53, 29 April 2008 (EDT)